Fix handling connection errors #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2017
WyriHaximus
approved these changes
Feb 13, 2017
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Looking forward to using the datagram and socket-client, not very keep on making this blocking
jsor
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a connection error will throw an uncaught exception that will bubble up to the upper-most exception handler.
This PR changes it to simply reject the promise as excepted.
Note that this does not address #19, i.e. the connection is still blocking.
I'll file a new PR for this (unrelated issue) soon.
Fixes / closes #16
Fixes / closes #13
Supersedes / closes #22