Support parsing resolv.conf via Config and deprecate FileSystemFactory #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Rebased now that #93 is in This means that this now applies appropriate DNS settings on Unix-based systems (Linux, Mac OS X and more) automatically. A follow-up PR will add support for Windows. |
jsor
approved these changes
Feb 26, 2018
WyriHaximus
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements parsing the
resolv.conffile in order to detect system default nameserver configuration. This file is present on most systems and will very likely cover the 90% use case (it is not present on Windows systems). This PR includes some trivial "autodetection" code in the examples to show how this can be used in higher level applications (see also reactphp/socket#90).This does not implement any other "autodection" mechanisms for other systems. In my opinion, the remainder is best discussed in a separate ticket.
Resolves / closes #29
Supersedes / closes #52, thank you @WyriHaximus
Inspired by #75