Improve Composer suggest description to detail for which loop implementation they are #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboden
approved these changes
Oct 31, 2017
cboden
reviewed
Oct 31, 2017
composer.json
Outdated
| "ext-libevent": ">=0.1.0", | ||
| "ext-event": "~1.0", | ||
| "ext-libev": "*" | ||
| "ext-libevent": ">=0.1.0 for LibEventLoop", |
Member
There was a problem hiding this comment.
Perhaps add something along the lines of "and PHP5 only"?
cebe
approved these changes
Oct 31, 2017
jsor
approved these changes
Nov 1, 2017
clue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our suggests are rather simple, IMHO it would look better if we suggest change the suggested extensions for which loop implementation they are.