Move TimerInterface one level up #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@clue you mentioned documentation needing updates. What did you have in mind? |
clue
approved these changes
Dec 19, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Changes LGTM 
👍
Arguably, the whole TimerInterface is currently undocumented, but we may as well take care of this in a follow-up PR 👍
src/LoopInterface.php
Outdated
| namespace React\EventLoop; | ||
|
|
||
| use React\EventLoop\Timer\TimerInterface; | ||
| use React\EventLoop\TimerInterface; |
WyriHaximus
changed the title
Member
Author
|
Will rebase and squash once approved |
clue
approved these changes
Dec 19, 2017
jsor
approved these changes
Dec 19, 2017
WyriHaximus
force-pushed
the
one-up-timer-interface
branch
from
876294b to
2f26416
Compare
This was referenced Dec 22, 2017
Merged
This was referenced Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.