Skip to content

Reduces fwrite() call length to one chunk #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clue merged 1 commit into from
Apr 3, 2018
Merged

Reduces fwrite() call length to one chunk #147

clue merged 1 commit into from
Apr 3, 2018

Conversation

@nawarian
Copy link
Contributor

@nawarian nawarian commented Jan 14, 2018 •
edited
Loading

As discussed here this PR reduces the string length to be written during the test to one single default chunk in order to avoid blocking calls and as well the EAGAIN error at MacOS devices.

@WyriHaximus WyriHaximus added this to the v0.5.0 milestone Mar 30, 2018
clue
clue approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! :shipit:

@clue clue merged commit 84de5da into reactphp:master Apr 3, 2018
@clue clue mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees

No one assigned

Labels

easy pick maintenance

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nawarian @jsor @WyriHaximus @clue