Skip to content

Throw BadMethodCallException on manual loop creating when required extension isn't installed #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
Mar 13, 2018
Merged

Throw BadMethodCallException on manual loop creating when required extension isn't installed #153

WyriHaximus merged 1 commit into from
Mar 13, 2018

Conversation

@WyriHaximus
Copy link
Member

@WyriHaximus WyriHaximus commented Feb 27, 2018 •
edited by clue
Loading

This came up during our hangouts call today. At the moment when creating a loop directly when the required extension is missing creating will fail epicly. This proposed PR will throw an BadMethodCallException when the required extension is missing.

@WyriHaximus WyriHaximus added this to the v0.5.0 milestone Feb 27, 2018
@WyriHaximus WyriHaximus requested review from clue and jsor February 27, 2018 21:11
@ivkalita
Copy link
Contributor

ivkalita commented Feb 28, 2018

Isn't it better to create RuntimeException descendant (something like LoopBackendMissedException) and throw it instead of RuntimeException?

@WyriHaximus
Copy link
Member Author

WyriHaximus commented Feb 28, 2018

@kaduev13 I would love that, but we're figuring out as a project what and where to place custom exceptions across our packages in the same way.

@WyriHaximus
Copy link
Member Author

WyriHaximus commented Mar 6, 2018

@clue @jsor ping updated

@clue clue changed the title Throw RuntimeException on loop creating when required extension isn't installed Throw BadMethodCallException on manual loop creating when required extension isn't installed Mar 13, 2018
clue
clue approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

Needs to be rebased on current master and commits should be squashed before merging.

@WyriHaximus
Copy link
Member Author

WyriHaximus commented Mar 13, 2018

@clue I'll do that when @jsor also approves 👍

@WyriHaximus WyriHaximus force-pushed the throwing_constructor branch from 5a47d01 to bf2e14b Compare March 13, 2018 12:07
@WyriHaximus WyriHaximus merged commit b94bc8e into reactphp:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

Assignees

No one assigned

Labels

easy pick help wanted maintenance

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@WyriHaximus @ivkalita @jsor @clue