Skip to content

Conversation

@lcobucci
Copy link
Contributor

This is already being done in other repos of the organisation, let's make it more consistent then =)

This is already being done in other repos of the organisation, let's
make it more consistent then =)
@lcobucci
Copy link
Contributor Author

These failures seem like flaky tests...

@WyriHaximus WyriHaximus requested review from WyriHaximus, clue and jsor June 26, 2018 05:43
Copy link
Member

@jsor jsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that PHPUnit already loads vendor/autoload.php 🙂👍

@clue clue added this to the v0.5.3 milestone Jun 26, 2018
@WyriHaximus WyriHaximus merged commit b2a3488 into reactphp:master Jun 26, 2018
@lcobucci lcobucci deleted the add-dev-namespace-to-autoloader branch June 26, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants