Incomplete control code while parsing chunked stream

[davidcole1340]

Hi,

I'm using wyrihaximus/react-guzzle-psr7 to send async requests with Guzzle HTTP, however, the server I am requesting has recently started using chunked HTTP requests. I saw that chunked requests was recently introduced into the HTTP client by the creator of the package I am using however I am still getting the error Stream ended with incomplete control code. Is this a client side problem?

Thanks

[clue]

Is this a client side problem?

We'll have to figure this out :-)

Have you checked the server is actually sending a valid chunked encoded stream? Can you post a public URL to test this?

The server might close the connection prematurely which would result in this error. Perhaps we may want to look into providing a non-strict parser (Be strict in what you send, but generous in what you receive).

[WyriHaximus]

Hey @uniquoooo the Stream ended with incomplete control code exception is thrown when the request ends in an unclean way. Do you have a easy way to reproduce this issue?

[davidcole1340]

Hi guys,

There isn't a public URL that I can post as it requires authorization, however, I can capture the response. Would it be fine if I capture it with curl -iv --raw?

Thanks

[clue]

Might be worth a try 👍 Otherwise a pcap (Wireshark etc.) may also help.

[davidcole1340]

I've uploaded it to GitHub gist here: https://gist.github.com/uniquoooo/c6c05261dbd67dd5f7c3ab5563927a14

[WyriHaximus]

@uniquoooo cheers, running tests with it ATM

[WyriHaximus]

@uniquoooo any change you can supply a pcap of the communication between your code and that server for a request that fails? Just put your gist into DecodeChunkedStreamTest as a data set, and it passed decoding the message.

If you don't want to share the pcap publicly (which I would discourage tbh) feel free to send it to the email address on my profile.

[davidcole1340]

@WyriHaximus I've captured the request but I'm not sure how to export it, could you help?

[WyriHaximus]

@uniquoooo Wireshark has a Save as option that just saves the entire capure. I can open the pcapng (or just pcap) file on my machine and go through the request.

[davidcole1340]

@WyriHaximus I've sent you an email with the file.

[WyriHaximus]

Managed to reproduce the issue with help from @uniquoooo, tracking down the cause of it and will submit a PR with a fix once I've came up with a solution.

[WyriHaximus]

So the chunked decoding parser is fine, the flaw turns out to be in the moment the headers are parsed and there is a bit of body coming with it from the stream. That bit of body was emitted from the response object while it should have been emitted from the stream. #68 is up to fix that.