Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Feb 5, 2018

This simple PR adds documentation for the Client class and how an explicit instance of ConnectorInterface can be passed to it.

Refs #46

@clue clue added this to the v0.5.7 milestone Feb 5, 2018
README.md Outdated
)
));

$client = new Client($loop);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$connector missing here? :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, updated :shipit:

@WyriHaximus WyriHaximus requested a review from jsor February 5, 2018 18:57
@WyriHaximus WyriHaximus merged commit 924baa2 into reactphp:master Feb 5, 2018
@clue clue deleted the client-docs branch February 7, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants