Ensure Request emits initial Response data as string #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Oct 19, 2016
Member
|
Thanks! Functionally, the changes LGTM 👍 However, semantically, does it make more sense to already cast this in the |
Member
Member
|
Awesome thanks 👍 |
Member
joelwurtz
referenced
this pull request
in php-http/react-adapter
Oct 24, 2016
It rely on react defered logic to handle asyncRequest and is able to mute a PSR7 request to a React Request. Then it take care of react request execution by listening all required events and processing de defered accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #65.