Skip to content

Replace deprecated SocketClient with new Socket component #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 2 commits into from
Apr 23, 2017
Merged

Replace deprecated SocketClient with new Socket component #84

WyriHaximus merged 2 commits into from
Apr 23, 2017

Conversation

@clue
Copy link
Member

@clue clue commented Apr 22, 2017

Builds on top of #74

@clue clue added this to the v0.5.0 milestone Apr 22, 2017
@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor April 22, 2017 22:20
WyriHaximus
WyriHaximus approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@WyriHaximus WyriHaximus merged commit 5902038 into reactphp:master Apr 23, 2017
@clue clue deleted the socket branch April 23, 2017 18:59
@clue clue mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

bc break easy pick maintenance new feature

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @jsor @WyriHaximus