Skip to content

Response closes after forwarding close event #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
Feb 21, 2017
Merged

Response closes after forwarding close event #131

WyriHaximus merged 1 commit into from
Feb 21, 2017

Conversation

@clue
Copy link
Member

@clue clue commented Feb 21, 2017

The Response now follows normal stream event semantics and actually closes after forwarding the close event. In the same vein, writing after an end() or close() is now a NOOP as expected.

Refs #104
Refs #130

@clue clue added this to the v0.6.0 milestone Feb 21, 2017
@clue clue mentioned this pull request Feb 21, 2017
Merged
@clue clue mentioned this pull request Feb 21, 2017
Merged
WyriHaximus
WyriHaximus approved these changes Feb 21, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 4468182 into reactphp:master Feb 21, 2017
@clue clue deleted the response-close branch February 22, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @jsor @WyriHaximus