Send '100 Continue' response automatically via Server #144
Conversation
README.md
Outdated
| sending the actual (large) message body. | ||
| In this case the server will automatically send an intermediary `HTTP/1.1 100 Continue` response to the client. | ||
| This ensures you will receive the request body without a delay as expected. | ||
| The [Response](#response) still needs to be created as described in the examples above. |
There was a problem hiding this comment.
@legionth This block of documentation should be in line with the Server class, can you verify?
There was a problem hiding this comment.
Added the block to the Server class
legionth
force-pushed
the
send-continue-automatically
branch
from
a91877f to
0c66dc1
Compare
src/Server.php
Outdated
| * headers with an additional `Expect: 100-continue` header and wait before | ||
| * sending the actual (large) message body. | ||
| * In this case the server will automatically send an intermediary `HTTP/1.1 100 Continue` response to the client. | ||
| * This ensures you will receive the request body without a delay as expected. |
There was a problem hiding this comment.
Does this really make sense as documentation for the ctor? 🙄
Also, may I ask you to wrap the lines at a reasonable length? Thanks!
There was a problem hiding this comment.
Moved the documentation to the Server docblock and adapted the line length.
legionth
force-pushed
the
send-continue-automatically
branch
from
0c66dc1 to
57a6e89
Compare
|
Ping @clue . Updated the documentation. |
README.md
Outdated
| `HTTP/1.1 100 Continue` response to the client. | ||
| This ensures you will receive the request body without a delay as expected. | ||
| The [Response](#response) still needs to be created as described in the | ||
| examples above. |
There was a problem hiding this comment.
👊 The text LGTM, but I still feel that this is the wrong location. Move this up where the request/body is described?
legionth
force-pushed
the
send-continue-automatically
branch
from
57a6e89 to
7ab9154
Compare
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Changes LGTM, now let's get this in and get the ball rolling (PSR-7 that is) 
4 participants
As preparation for the upcoming PSR-7 feature, this PR will remove the
expectsContinueandwriteContinuesmethods from the Response and Request classes, because it is not compatible with the ResponseInterface and the RequestInterface of PSR-7.The server sends now a the
HTTP/1.1 100 Continueresponse automatically.The possibility to handle this behavior is removed, but will be added again after the PSR-7 implemantation is completed.
Some of the details are already discussed in #109.