Add tests to test case sensitivity for ChunkedDecoder #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Mar 20, 2017
tests/ChunkedDecoderTest.php
Outdated
| $data = ''; | ||
| for ($i = 0; $i < $integer; $i++) { | ||
| $data .= '1'; | ||
| } |
jsor
approved these changes
Mar 20, 2017
legionth
force-pushed
the
test-case-sensitivity
branch
from
9b1ca03 to
38e741f
Compare
Contributor
Author
|
Ping @clue . Used |
mdrost
reviewed
Mar 20, 2017
tests/ChunkedDecoderTest.php
Outdated
| $this->input->emit('data', array("a\r\n0123456790\r\n")); | ||
| } | ||
|
|
||
| public function testCaseInsensitiyHexValuesInHeaderWillBeHandled() |
Contributor
Author
There was a problem hiding this comment.
Thank you! Changed name of the test.
legionth
force-pushed
the
test-case-sensitivity
branch
from
38e741f to
9bfd088
Compare
clue
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @mdrost who found a bug with case-insensitve chunk headers: reactphp/http-client#77
Luckily the Server is not affected. I added just some tests to verify this behavior.