Skip to content

Conversation

@WyriHaximus
Copy link
Member

I've been working on some performance improvements for the middleware runner. In order to test those I've written this benchmark.

@WyriHaximus WyriHaximus added this to the v0.8.0 milestone Sep 30, 2017
@WyriHaximus WyriHaximus requested review from clue and jsor September 30, 2017 23:28
@WyriHaximus WyriHaximus force-pushed the middleware-runner-benchmark branch from 8ad3d03 to 08e65e3 Compare October 1, 2017 12:43
@WyriHaximus WyriHaximus force-pushed the middleware-runner-benchmark branch from 08e65e3 to 11fe49d Compare October 10, 2017 20:09
@WyriHaximus
Copy link
Member Author

@clue as discussed during hangouts I've updated the PR and moved this benchmark to the tests directory. /cc @jsor

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, no objections, let's get this in! :shipit:

@WyriHaximus WyriHaximus merged commit c6ceaf5 into reactphp:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants