Test middleware runner to ensure next handler can be called more than once #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
middleware-runner-correction-tests
branch
from
2837578 to
d648444
Compare
clue
reviewed
Nov 7, 2017
clue
reviewed
Nov 13, 2017
tests/MiddlewareRunnerTest.php
Outdated
| } | ||
| } | ||
|
|
||
| public function testCorruptMiddlewareStack() |
Member
There was a problem hiding this comment.
The method name seems to imply something is "corrupt" here, can you update this to emphasize what is being tested here? :-) Otherwise LGTM 👍
Member
Author
|
Will rebase it once approved |
jsor
reviewed
Nov 14, 2017
tests/MiddlewareRunnerTest.php
Outdated
| } | ||
| } | ||
|
|
||
| public function testNextCanBeRunMoreThenOnceWithoutCorruptingTheMiddlewareStack() |
jsor
approved these changes
Nov 14, 2017
clue
changed the title
clue
approved these changes
Nov 14, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
LGTM, please squash and let's get this in! 
WyriHaximus
force-pushed
the
middleware-runner-correction-tests
branch
2 times, most recently
from
958a1e8 to
fde33f7
Compare
Member
Author
|
Err whoops I think I accedently rebased my commit away 0_O. Will file a new PR -.- |
WyriHaximus
force-pushed
the
middleware-runner-correction-tests
branch
from
fde33f7 to
345b28e
Compare
Member
Author
|
Fixed the branch thanks to @jsor as mentioned in #245 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.