Move @internal classes to React\Http\Io namespace
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You didn't update the benchmark: https://travis-ci.org/reactphp/http/jobs/303687422#L663-L671 |
Member
Author
|
@WyriHaximus Thanks for spotting, updated! |
WyriHaximus
approved these changes
Nov 17, 2017
Member
|
@clue cheers, LGTM |
jsor
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR only re-arranges our internal classes into a new
React\Http\Ionamespace to make this project more approachable to contributors. I've added some documentation to describe their functions and actively discourage relying on these classes.These classes have already been marked as
@internaland there's no reason for consumer code to rely on this, so this is technically not a BC break. Given that this is planned for the v0.8.0 release, this should be a very safe move.