Expose Transfer-Encoding: chunked response header and fix chunked responses for HEAD requests
#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dedicated client-side chunked decoder in favor of existing server-side chunked decoder. Unify handling to always skip (unused) trailers for both sides.
jsor
approved these changes
Jul 28, 2020
WyriHaximus
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset allows exposing the
Transfer-Encoding: chunkedresponse header for the HTTP client and fixes parsing chunked responses forHEADrequests. This is mostly used internally only and the APIs are not affected otherwise, so I do not consider this a BC break.This also applies some internal refactoring / cleanup to unify the chunked decoder and always skip trailers also for the HTTP server as well as the HTTP client. This removes the dedicated client-side chunked decoder in favor of the existing server-side chunked decoder. Unify handling to always skip (unused) trailers for both sides.
Builds on top of #380 and #368