Internal refactoring to simplify buffer() function #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the extra Deferred and directly uses reject instead.
kelunik
force-pushed
the
simplify-buffer
branch
from
0be5dbb to
41b8f3e
Compare
jsor
approved these changes
Oct 26, 2017
clue
approved these changes
Oct 27, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Thank you, changes LGTM! 👍
While we're at it, does it make sense to also get rid of the below then() handler as part of this PR?
clue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the extra Deferred and directly uses reject instead.