Check if the function is declared before declaring it.

[NikoGrano]

In case you use pthreads or something else related to threading you might encounter this issue. It happens only with functions and is fixable only by adding these checks. Another way to avoid this is to wrap functions as static into classes.

[trowski]

Sounds like you're inheriting class and function definitions with pthreads, then including the Composer autoloader again. If this is the case, that's the real problem to be fixed.

If there is some other scenario that can lead to this problem, please describe it.

[NikoGrano]

Well, yes I need to include autoloader again. Without it I get undefined error. 🙃
Will be checking few probably causes tomorrow.

[trowski]

I recommend using PTHREADS_INHERIT_INI only and then including the Composer autoloader in the thread.

[NikoGrano]

I'm using none currently, but lez see...

[NikoGrano]

@trowski Confirmed same issue.

[NikoGrano]

@trowski Check the gist. https://gist.github.com/Niko9911/12fb01b6becba817e4a42bd1ab3f5dae

[WyriHaximus]

This makes total sense to me but I rather see that we use a functions_include.php like we do in other packages, for example: https://github.com/reactphp/promise-stream/blob/master/src/functions_include.php

[NikoGrano]

@WyriHaximus Thank you!

I will make requested changes after I finish some critical work.

[trowski]

@Niko9911 There's something else going wrong. We use pthreads in amphp/parallel and have no issues with functions being redeclared, and we have no conditionals around function declarations.

Here is our definition of Thread::run() and where we call Thread::start().

[NikoGrano]

Maybe because itäs used by pool?

[NikoGrano]

@WyriHaximus Requested changes are made.

[WyriHaximus]

LGTM 👍

One more thing, could you squash them into one commit?

[NikoGrano]

Sure!

[NikoGrano]

Done, ty.

[NikoGrano]

Status? @clue

[WyriHaximus]

Cheers, will tag this shortly 👍

[NikoGrano]

THANK YOU EVERYBODY!

[WyriHaximus]

Ok v1.5.1 has been released