Port memory improvements from 2.x to master #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
port-memory-improvements-from-2.x
branch
3 times, most recently
from
b76a4e4 to
e5312e4
Compare
WyriHaximus
changed the title
clue
reviewed
Nov 26, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for taking a look at this! Direction seems good, but some changes seem to be missing, can you take a look at this? 👍
WyriHaximus
force-pushed
the
port-memory-improvements-from-2.x
branch
from
d6cdc7b to
afb3276
Compare
clue
approved these changes
Dec 2, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Changes LGTM, thank you for looking into this! 
🎉
jsor
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked and ported the following PR commits targeting
2.xinto this PR to port the memory improvements from them into3.x: #113, #115, #116, #117, #118, #119, #123, #124