Skip to content

Conversation

@woodongwong
Copy link
Contributor

When I execute phpunit, it prompts me Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 20480 bytes), which I know I can fix by modifying php.ini. I think I can reduce the promises depth, i.e. I can not modify the memory_limit (default 128M) and also ensure the correct test, thanks. (very sorry, English is not my native language)

@SimonFrings
Copy link
Member

SimonFrings commented Oct 6, 2021

@woodongwong thanks for looking into this 👍
You're right with the memory_limit being 128M by default, so i don't see any reason to reject your changes.

For now you can raise your memory_limit by executing the test suite like this:

$ php -d memory_limit=256M vendor/bin/phpunit

@clue @WyriHaximus what do you think about this?

@clue clue added this to the v3.0.0 milestone Oct 6, 2021
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woodongwong Small change, but noticeable improvement with PHP's default configuration, thank you for looking into this! :shipit:

@clue clue requested a review from WyriHaximus October 6, 2021 11:26
@WyriHaximus WyriHaximus merged commit babade6 into reactphp:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants