Skip to content

Add test group to skip integration tests relying on internet connection #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsor merged 2 commits into from
Jan 5, 2018
Merged

Add test group to skip integration tests relying on internet connection #146

jsor merged 2 commits into from
Jan 5, 2018

Conversation

@clue
Copy link
Member

@clue clue commented Jan 5, 2018

No description provided.

@clue clue added this to the v0.8.8 milestone Jan 5, 2018
WyriHaximus
WyriHaximus approved these changes Jan 5, 2018
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍝

@jsor jsor merged commit 276b864 into reactphp:master Jan 5, 2018
@clue clue deleted the tests branch January 6, 2018 00:17
@clue clue mentioned this pull request Jan 6, 2018
Merged
This was referenced Jan 14, 2018
Merged
Merged
@clue clue mentioned this pull request May 6, 2018
Merged
@clue clue mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

easy pick maintenance

Projects

None yet

Milestone

v0.8.8

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @jsor @WyriHaximus