Avoid possibility of missing remote address when TLS handshake fails #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a race condition where the remote address could appear to be "emtpy" in the server exception message, that could occur when the connection to the peer was already closed during the TLS handshake. This is simply avoided by getting the remote address prior to starting the TLS handshake, in which case the remote address is known to exist.
jsor
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition where the remote address could appear to be
"emtpy" in the server exception message, that could occur when the
connection to the peer was already closed during the TLS handshake. This
is simply avoided by getting the remote address prior to starting the
TLS handshake, in which case the remote address is known to exist.
Builds on top of #185, discovered while working on #186