Example 99 improvements #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jan 22, 2019
clue
reviewed
Jan 23, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Good catch! This repo still has a localhost_swordfish.pem and a number of references to this in the tests, do you think this should be updated as part of this PR? 👍
Member
Author
|
@clue Yes, i noticed that as well. But i didn't find any direct references to this script. It's still possible to generate a cert with the password |
Member
|
@jsor Good, no objections then 👍 |
clue
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes and improvements for
examples/99-generate-self-signed.phpdiscovered in #189