Improve error reporting when TCP/IP connection fails (happy eyeballs) #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use one-off timers that will be scheduled only when a following connection attempt should be started instead of using a dangling periodic timer that could possibly keep running even when no connection attempts are scheduled anymore.
WyriHaximus
approved these changes
May 12, 2020
jsor
approved these changes
May 12, 2020
This was referenced May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error reporting when TCP/IP connection fails (happy eyeballs). The rejection message now always contains the underlying TCP/IP error message with more details.
Additionally, improve timer logic for next attempt timer and fix leftover timer reference.
Use one-off timers that will be scheduled only when a following
connection attempt should be started instead of using a dangling
periodic timer that could possibly keep running even when no connection
attempts are scheduled anymore.
Builds on top of #230, #224 and #225
Refs #171 and others