Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Apr 13, 2023

This changeset improves errno detection for failed connections without ext-sockets. Reporting the errstr already works on most platforms even when ext-sockets is not installed, consistently reporting the correct errno previously required ext-sockets. With these changes applied, we now also take the errno constants from ext-pcntl and ext-posix into account. This is particularly useful for lightweight container images (Docker) that by default come with ext-sockets and ext-pcntl disabled but ext-posix enabled. All extensions remain entirely optional.

Link dump:

Builds on top of #271, #267, #266 and others

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 7da8a6b into reactphp:1.x Apr 13, 2023
@clue clue deleted the errno-pcntl branch April 13, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants