Add functional integration tests #54
Conversation
|
Here's a dependency graph that shows this cyclic dependency (generated via https://github.com/clue/graph-composer): The Note that this only applies when this is the root package, i.e. it does happen in a local test setup but will not happen when you use this project as a library and add any of these packages as a normal dependency. One possible way to avoid this is to explicitly define the root package version as per https://getcomposer.org/doc/03-cli.md#composer-root-version: $ COMPOSER_ROOT_VERSION=`git describe --abbrev=0` composer update |
clue
changed the title
|
PR updated and ready for review |
README.md
Outdated
|
|
||
| ## Tests | ||
|
|
||
| The run the test suite, you first need to clone this repo and then install all |
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Accept from that one typo LGTM 
We currently have an indirect cyclic dependency between socket -> socket-client -> dns -> socket which causes the test setup to fail otherwise.
clue
force-pushed
the
integration-tests
branch
from
99e37e9 to
8740211
Compare
|
Thanks for spotting! Amended the last commit |
First class support for PHP7 and HHVM
3 participants
This simple PR aims to add a functional integration test (which also happens to be a prerequisite for implementing #24).
Unfortunately, this simple change introduces an indirect cyclic dependency between
socket -> socket-client -> dns -> socketwhich causes the test setup to fail. I'm opening this PR in the hope to propose and discuss a possible solution.