Do not expose $master property and accept any ServerInterface for SecureServer #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interfering with this (previously public) property could introduce some very subtle bugs, so it's best to simply avoid exposing it. Empirical evidence seems to suggest this isn't used much outside of this package anyway. Inside this package, we can safely replace all references to it with references to child sockets created upon connection.
jsor
approved these changes
Feb 8, 2017
WyriHaximus
approved these changes
Feb 8, 2017
This was referenced Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfering with this (previously public) property could introduce some very subtle bugs, so it's best to simply avoid exposing it.
Empirical evidence seems to suggest this isn't used much outside of this package anyway.
Inside this package, we can safely replace all references to it with references to child sockets created upon connection.
Also, the
SecureServernow supports any underlyingServerInterface(advanced usage) and no longer relies on a concrete implementation.Builds on top of #69