Skip to content

Add .gitattributes to exclude dev files from exports #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clue merged 1 commit into from
Dec 21, 2019
Merged

Add .gitattributes to exclude dev files from exports #144

clue merged 1 commit into from
Dec 21, 2019

Conversation

@reedy
Copy link
Contributor

@reedy reedy commented Dec 1, 2019 •
edited
Loading

As per discussion at reactphp/promise#153

@reedy reedy changed the title Create .gitattributes Add .gitattributes to exclude dev files from exports Dec 1, 2019
@WyriHaximus WyriHaximus added this to the v1.1.1 milestone Dec 2, 2019
clue
clue reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedy This PR seems to contain some unrelated changes (and has strange commit authorship). The changes may make sense, but may I ask you to not mix this into this PR and file a dedicated PR if deemed useful? 👍

WyriHaximus
WyriHaximus approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@clue clue merged commit 2b9e19d into reactphp:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@reedy @jsor @WyriHaximus @clue