Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Dec 13, 2025

* See discussion in rake-compiler/rake-compiler#247
  it is messy if that's not the case and also creates inconsistencies
  based on which Java tool/executable is used.
@eregon
Copy link
Member Author

eregon commented Dec 13, 2025

It works well, and Node.js path.join does the right thing:
https://github.com/ruby/setup-ruby/actions/runs/20197116199/job/57982688126?pr=836#step:3:36

Adding C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.9-10.0\x64\bin to Path
...
Run # Show PATH with Powershell
C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.9-10.0\x64\bin
D:\jruby-10.0.2.0\bin

@eregon eregon merged commit ac793fd into ruby:master Dec 13, 2025
209 checks passed
@eregon eregon deleted the java_home_bin_in_path branch December 13, 2025 20:06
mergify bot added a commit to robfrank/linklift that referenced this pull request Dec 15, 2025
Bumps the github-actions group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [anchore/scan-action](https://github.com/anchore/scan-action) | `7.2.1` | `7.2.2` |
| [github/codeql-action](https://github.com/github/codeql-action) | `4.31.7` | `4.31.8` |
| [ruby/setup-ruby](https://github.com/ruby/setup-ruby) | `1.269.0` | `1.270.0` |
| [updatecli/updatecli-action](https://github.com/updatecli/updatecli-action) | `2.97.0` | `2.98.0` |
| [robfrank/kamal-accessories-updater](https://github.com/robfrank/kamal-accessories-updater) | `25.11.2` | `25.12.1` |
Updates `anchore/scan-action` from 7.2.1 to 7.2.2
Release notes

*Sourced from [anchore/scan-action's releases](https://github.com/anchore/scan-action/releases).*

> v7.2.2
> ------
>
> New in scan-action v7.2.2
> -------------------------
>
> * update Grype to v0.104.2 ([#557](https://redirect.github.com/anchore/scan-action/issues/557)) [[[anchore-actions-token-generator[bot]](https://github.com/apps/anchore-actions-token-generator)]([https://github.com/[anchore-actions-token-generator[bot]](https://github.com/apps/anchore-actions-token-generator))]](https://github.com/%5Banchore-actions-token-generator%5Bbot%5D%5D(https://github.com/apps/anchore-actions-token-generator))%5D)
> * bump glob from 10.4.5 to 10.5.0 ([#546](https://redirect.github.com/anchore/scan-action/issues/546)) [[[dependabot[bot]](https://github.com/apps/dependabot)]([https://github.com/[dependabot[bot]](https://github.com/apps/dependabot))]](https://github.com/%5Bdependabot%5Bbot%5D%5D(https://github.com/apps/dependabot))%5D)


Commits

* [`3c9a191`](anchore/scan-action@3c9a191) chore(deps): update Grype to v0.104.2 ([#557](https://redirect.github.com/anchore/scan-action/issues/557))
* [`0a9fbe8`](anchore/scan-action@0a9fbe8) chore(deps-dev): bump lint-staged from 16.2.6 to 16.2.7 ([#547](https://redirect.github.com/anchore/scan-action/issues/547))
* [`5ac7f2a`](anchore/scan-action@5ac7f2a) chore(deps-dev): bump prettier from 3.6.2 to 3.7.4 ([#555](https://redirect.github.com/anchore/scan-action/issues/555))
* [`563e915`](anchore/scan-action@563e915) chore(deps): bump peter-evans/create-pull-request from 7.0.8 to 7.0.11 ([#556](https://redirect.github.com/anchore/scan-action/issues/556))
* [`49c6d26`](anchore/scan-action@49c6d26) chore(deps): bump actions/checkout from 5.0.0 to 6.0.1 ([#554](https://redirect.github.com/anchore/scan-action/issues/554))
* [`77906c3`](anchore/scan-action@77906c3) chore(deps): bump actions/setup-node from 6.0.0 to 6.1.0 ([#553](https://redirect.github.com/anchore/scan-action/issues/553))
* [`ed82e81`](anchore/scan-action@ed82e81) chore(deps): bump glob from 10.4.5 to 10.5.0 ([#546](https://redirect.github.com/anchore/scan-action/issues/546))
* See full diff in [compare view](anchore/scan-action@40a61b5...3c9a191)
  
Updates `github/codeql-action` from 4.31.7 to 4.31.8
Release notes

*Sourced from [github/codeql-action's releases](https://github.com/github/codeql-action/releases).*

> v4.31.8
> -------
>
> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> 4.31.8 - 11 Dec 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.23.8. [#3354](https://redirect.github.com/github/codeql-action/pull/3354)
>
> See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v4.31.8/CHANGELOG.md) for more information.


Changelog

*Sourced from [github/codeql-action's changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md).*

> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> [UNRELEASED]
> ------------
>
> No user facing changes.
>
> 4.31.8 - 11 Dec 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.23.8. [#3354](https://redirect.github.com/github/codeql-action/pull/3354)
>
> 4.31.7 - 05 Dec 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.23.7. [#3343](https://redirect.github.com/github/codeql-action/pull/3343)
>
> 4.31.6 - 01 Dec 2025
> --------------------
>
> No user facing changes.
>
> 4.31.5 - 24 Nov 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.23.6. [#3321](https://redirect.github.com/github/codeql-action/pull/3321)
>
> 4.31.4 - 18 Nov 2025
> --------------------
>
> No user facing changes.
>
> 4.31.3 - 13 Nov 2025
> --------------------
>
> * CodeQL Action v3 will be deprecated in December 2026. The Action now logs a warning for customers who are running v3 but could be running v4. For more information, see [Upcoming deprecation of CodeQL Action v3](https://github.blog/changelog/2025-10-28-upcoming-deprecation-of-codeql-action-v3/).
> * Update default CodeQL bundle version to 2.23.5. [#3288](https://redirect.github.com/github/codeql-action/pull/3288)
>
> 4.31.2 - 30 Oct 2025
> --------------------
>
> No user facing changes.
>
> 4.31.1 - 30 Oct 2025
> --------------------
>
> * The `add-snippets` input has been removed from the `analyze` action. This input has been deprecated since CodeQL Action 3.26.4 in August 2024 when this removal was announced.
>
> 4.31.0 - 24 Oct 2025
> --------------------
>
> * Bump minimum CodeQL bundle version to 2.17.6. [#3223](https://redirect.github.com/github/codeql-action/pull/3223)
> * When SARIF files are uploaded by the `analyze` or `upload-sarif` actions, the CodeQL Action automatically performs post-processing steps to prepare the data for the upload. Previously, these post-processing steps were only performed before an upload took place. We are now changing this so that the post-processing steps will always be performed, even when the SARIF files are not uploaded. This does not change anything for the `upload-sarif` action. For `analyze`, this may affect Advanced Setup for CodeQL users who specify a value other than `always` for the `upload` input. [#3222](https://redirect.github.com/github/codeql-action/pull/3222)
>
> 4.30.9 - 17 Oct 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.23.3. [#3205](https://redirect.github.com/github/codeql-action/pull/3205)
> * Experimental: A new `setup-codeql` action has been added which is similar to `init`, except it only installs the CodeQL CLI and does not initialize a database. Do not use this in production as it is part of an internal experiment and subject to change at any time. [#3204](https://redirect.github.com/github/codeql-action/pull/3204)

... (truncated)


Commits

* [`1b168cd`](github/codeql-action@1b168cd) Merge pull request [#3355](https://redirect.github.com/github/codeql-action/issues/3355) from github/update-v4.31.8-1b0b941e1
* [`120f277`](github/codeql-action@120f277) Update changelog for v4.31.8
* [`1b0b941`](github/codeql-action@1b0b941) Merge pull request [#3354](https://redirect.github.com/github/codeql-action/issues/3354) from github/update-bundle/codeql-bundle-v2.23.8
* [`db812c1`](github/codeql-action@db812c1) Add changelog note
* [`2930dba`](github/codeql-action@2930dba) Update default bundle to codeql-bundle-v2.23.8
* [`c43362b`](github/codeql-action@c43362b) Merge pull request [#3340](https://redirect.github.com/github/codeql-action/issues/3340) from github/kaspersv/check-for-overlayBaseSpecifier
* [`002a7f2`](github/codeql-action@002a7f2) Overlay: log overlayBaseSpecifier at debug log-level
* [`5b7e7fc`](github/codeql-action@5b7e7fc) Update src/codeql.ts
* [`149d184`](github/codeql-action@149d184) Merge pull request [#3345](https://redirect.github.com/github/codeql-action/issues/3345) from github/mergeback/v4.31.7-to-main-cf1bb45a
* [`97c2630`](github/codeql-action@97c2630) Rebuild
* Additional commits viewable in [compare view](github/codeql-action@cf1bb45...1b168cd)
  
Updates `ruby/setup-ruby` from 1.269.0 to 1.270.0
Release notes

*Sourced from [ruby/setup-ruby's releases](https://github.com/ruby/setup-ruby/releases).*

> v1.270.0
> --------
>
> What's Changed
> --------------
>
> * Bump actions/checkout from 5 to 6 by [`@​dependabot`](https://github.com/dependabot)[bot] in [ruby/setup-ruby#830](https://redirect.github.com/ruby/setup-ruby/pull/830)
> * When setting $JAVA\_HOME also add $JAVA\_HOME/bin to PATH by [`@​eregon`](https://github.com/eregon) in [ruby/setup-ruby#836](https://redirect.github.com/ruby/setup-ruby/pull/836)
>
> **Full Changelog**: <ruby/setup-ruby@v1.269.0...v1.270.0>


Commits

* [`ac793fd`](ruby/setup-ruby@ac793fd) When setting $JAVA\_HOME also add $JAVA\_HOME/bin to PATH
* [`5f8a775`](ruby/setup-ruby@5f8a775) macos-13 is gone
* [`30a6546`](ruby/setup-ruby@30a6546) Bump actions/checkout from 5 to 6
* See full diff in [compare view](ruby/setup-ruby@d697be2...ac793fd)
  
Updates `updatecli/updatecli-action` from 2.97.0 to 2.98.0
Release notes

*Sourced from [updatecli/updatecli-action's releases](https://github.com/updatecli/updatecli-action/releases).*

> v2.98.0 🌈
> ---------
>
> Changes
> -------
>
> * Bump "`@​types/node`" package version @[updateclibot[bot]](https://github.com/apps/updateclibot) ([#991](https://redirect.github.com/updatecli/updatecli-action/issues/991))
> * deps: update updatecli version to v0.112.0 @[updateclibot[bot]](https://github.com/apps/updateclibot) ([#990](https://redirect.github.com/updatecli/updatecli-action/issues/990))
> * Bump "`@​types/node`" package version @[updateclibot[bot]](https://github.com/apps/updateclibot) ([#989](https://redirect.github.com/updatecli/updatecli-action/issues/989))
>
> Contributors
> ------------
>
> [`@​updateclibot`](https://github.com/updateclibot)[bot] and [updateclibot[bot]](https://github.com/apps/updateclibot)


Commits

* [`b846825`](updatecli/updatecli-action@b846825) Bump "`@​types/node`" package version ([#991](https://redirect.github.com/updatecli/updatecli-action/issues/991))
* [`fc534a8`](updatecli/updatecli-action@fc534a8) deps: update updatecli version to v0.112.0 ([#990](https://redirect.github.com/updatecli/updatecli-action/issues/990))
* [`0d62933`](updatecli/updatecli-action@0d62933) Bump "`@​types/node`" package version ([#989](https://redirect.github.com/updatecli/updatecli-action/issues/989))
* See full diff in [compare view](updatecli/updatecli-action@9a21b69...b846825)
  
Updates `robfrank/kamal-accessories-updater` from 25.11.2 to 25.12.1
Release notes

*Sourced from [robfrank/kamal-accessories-updater's releases](https://github.com/robfrank/kamal-accessories-updater/releases).*

> Release v25.12.1
> ----------------
>
> What's Changed
> --------------
>
> * Merge pull request [#7](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/7) from robfrank/dependabot/github\_actions/github-actions-0b8390718f (231507f)
> * Merge pull request [#8](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/8) from robfrank/dependabot/github\_actions/actions/checkout-6.0.0 (7cad6b2)
> * Bump actions/checkout from 5.0.0 to 6.0.0 (7f31bd5)
> * Bump peter-evans/create-pull-request in the github-actions group (a8d7de4)
> * Merge pull request [#6](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/6) from emadb/patch-1 (18beb5d)
> * update Readme to match the latest version (aab2b06)
>
> Usage
> -----
>
> To use this version in your workflows:
>
> ```
> - name: Update Kamal accessories
>   uses: robfrank/[email protected]
>   with:
>     config-dir: config
>     mode: update-all
> ```
>
> **Full Changelog**: <robfrank/kamal-accessories-updater@...v25.12.1>


Commits

* [`231507f`](robfrank/kamal-accessories-updater@231507f) Merge pull request [#7](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/7) from robfrank/dependabot/github\_actions/github-actions-...
* [`7cad6b2`](robfrank/kamal-accessories-updater@7cad6b2) Merge pull request [#8](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/8) from robfrank/dependabot/github\_actions/actions/checkou...
* [`7f31bd5`](robfrank/kamal-accessories-updater@7f31bd5) Bump actions/checkout from 5.0.0 to 6.0.0
* [`a8d7de4`](robfrank/kamal-accessories-updater@a8d7de4) Bump peter-evans/create-pull-request in the github-actions group
* [`18beb5d`](robfrank/kamal-accessories-updater@18beb5d) Merge pull request [#6](https://redirect.github.com/robfrank/kamal-accessories-updater/issues/6) from emadb/patch-1
* [`aab2b06`](robfrank/kamal-accessories-updater@aab2b06) update Readme to match the latest version
* See full diff in [compare view](robfrank/kamal-accessories-updater@935fbb8...231507f)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant