Skip to content

Conversation

@zenspider
Copy link
Member

No description provided.

@zenspider
Copy link
Member Author

@eregon pls help. I don't know what I'm doing. I'm still seeing untagged urls trying to be fetched.

It appears to be in dist/index.js but that wasn't ever modified by you?

Feel free to tweak my commit as appropriate.

@eregon
Copy link
Member

eregon commented Dec 18, 2025

This diff looks good, it's the same as running ruby generate-windows-versions.rb locally.
But indeed the pre-commit hook needs to be run to update dist/index.js as documented in CONTRIBUTING.md.
I'll do it this time.

@eregon eregon force-pushed the zenspider__fix_windows branch from 25f8a36 to 5fbb8c6 Compare December 18, 2025 22:13
@eregon eregon merged commit ed55d55 into ruby:master Dec 18, 2025
209 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants