Skip to content

Mention Warning[]= that can be used to suppress the deprecation warnings #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mame merged 6 commits into from
Dec 25, 2019
Merged

Mention Warning[]= that can be used to suppress the deprecation warnings #2324

mame merged 6 commits into from
Dec 25, 2019

Conversation

@mame
Copy link
Member

@mame mame commented Dec 23, 2019

No description provided.

@mame mame requested a review from a team as a code owner December 23, 2019 02:47
@riseshia riseshia mentioned this pull request Dec 23, 2019
Closed
@mame mame force-pushed the ruby3-keywords-warnings-be-suppressed-by-new-api branch from ad960cc to 7e2908b Compare December 24, 2019 07:31
@ismailarilik
Copy link
Member

ismailarilik commented Dec 24, 2019

I wonder why wasn't this PR emailed to me? I am "Watching" the repository.

@ismailarilik
Copy link
Member

ismailarilik commented Dec 24, 2019

Sorry, it came but I have missed it somehow.

@stomar
Copy link
Contributor

stomar commented Dec 24, 2019

IMO the <del> section could be removed completely.

From the ChangeLog section it is obvious that a change was made, and the previous versions could be inspected in this repo. (But I do not think the changes of these warning messages during the preview/rc phase would be very relevant as soon as 2.7.0 is released,)

stomar
stomar reviewed Dec 24, 2019
View reviewed changes
Copy link
Contributor

@stomar stomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use „History“ like in some other posts instead of „ChangeLog“, and use an international date format.

mame and others added 2 commits December 25, 2019 10:04
@mame @stomar
Update en/news/_posts/2019-12-12-separation-of-positional-and-keyword…
fb715f9 
…-arguments-in-ruby-3-0.md

Co-Authored-By: Marcus Stollsteimer <[email protected]>
@mame @stomar
Update en/news/_posts/2019-12-12-separation-of-positional-and-keyword…
c727479 
…-arguments-in-ruby-3-0.md

Co-Authored-By: Marcus Stollsteimer <[email protected]>
@mame
Copy link
Member Author

mame commented Dec 25, 2019

Thanks! I've merged your suggestions.

@mame
Copy link
Member Author

mame commented Dec 25, 2019

And removed <del>.

I'd like to merge this before Ruby 2.7.0 release (today 😏).

@ismailarilik
Copy link
Member

ismailarilik commented Dec 25, 2019

@mame as I saw, some warnings didn't converted to their new forms. It will cause inconsistencies through the post. You should think to update them. You can find them by searching these sentences in the post source:

  1. The last argument is used as keyword parameters
  2. The keyword argument is passed as the last hash parameter
  3. The last argument is split into positional and keyword parameters

@mame mame merged commit c25d7b8 into ruby:master Dec 25, 2019
@mame mame deleted the ruby3-keywords-warnings-be-suppressed-by-new-api branch December 25, 2019 10:42
ismailarilik added a commit that referenced this pull request Dec 26, 2019
@ismailarilik
Follow #2324 (tr) (#2329)
a595a38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stomar stomar stomar left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mame @ismailarilik @stomar