Refactor gimli implementation to avoid mk! macro
#379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
no-macros
branch
from
79a1933 to
cb8c061
Compare
This commit refactors a bit to avoid using a macro for constructing a `Mapping` and instead adds a dedicated function. This is a bit easier to navigate and will hopefully help deduplicate construction of a `Mapping` as well.
alexcrichton
force-pushed
the
no-macros
branch
from
cb8c061 to
81590b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors a bit to avoid using a macro for constructing a
Mappingand instead adds a dedicated function. This is a bit easier tonavigate and will hopefully help deduplicate construction of a
Mappingas well.