-
Notifications
You must be signed in to change notification settings - Fork 144
Add Visual Studio 2026 support #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 waiting on this to be merged 🙏 |
|
+1 waiting on this to be merged as well, we've all started uninstalling Visual Studio 2022 in favor of Visual Studio 2026 at our organization, and it's going to become a pain point very quickly. |
|
Hi — quick question / suggestion: for Visual Studio versions >= 17.0 (VS2022 and later), why not default to the Ninja CMake generator? Visual Studio itself defaults to Ninja for CMake projects, so preferring Ninja when the detected VS version is >= 17.0 would avoid having to update the generator list every time a new VS version is released and would make builds more consistent across developer environments. Could we change the generator selection logic to prefer "Ninja" for VS >= 17.0, and fall back to the current behavior otherwise? |
I don't think switching the default generator to Ninja will actually solve the issue regarding support for newer Visual Studio versions. While using Ninja avoids generating
Conclusion: Therefore, we should stick to the existing logic and manually update the |
|
In case someone runs in to problems, Im getting the problem mentioned in the comment linked below when using this pullrequest on master, works fine when I apply the same change to latest release though. |
|
I'm not (usually) a cmake-rs maintainer but this looks trivially correct to me so I'll merge it. We'll still need a new cmake-rs release though. If there's some other improvement that can be made here then please do open an issue to discuss it. |
## 🤖 New release * `cmake`: 0.1.54 -> 0.1.55 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.1.55](v0.1.54...v0.1.55) - 2025-12-11 ### Other - Remove the `\\?\` prefix from paths ([#259](#259)) - Add Visual Studio 2026 support ([#255](#255)) - Make sure that cmake generate build files in current dir ([#194](#194)) - Set the MSRV to 1.65 and test this in CI - Canonicalize the build directory - Use `eprintln` instead to print the command running next ([#191](#191)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I have tested this and it appears to work well.
Fixes #253