Skip to content

Conversation

@Thomasdezeeuw
Copy link
Contributor

Introduced in FreeBSD 12.0.

Manual page: https://www.freebsd.org/cgi/man.cgi?query=getrandom.

Not sure if the constants should be c_int, just matching the flags argument in the function, in c they're macros.

@rust-highfive
Copy link

r? @JohnTitor

(rust_highfive has picked a reviewer for you, use r? to override)

@Thomasdezeeuw Thomasdezeeuw marked this pull request as ready for review November 24, 2020 10:38
Copy link

@cemeyer cemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 27, 2020

📌 Commit 99b3635 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 27, 2020

⌛ Testing commit 99b3635 with merge 8e62c98...

@bors
Copy link
Contributor

bors commented Nov 27, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 8e62c98 to master...

@bors bors merged commit 8e62c98 into rust-lang:master Nov 27, 2020
josephlr added a commit to josephlr/libc that referenced this pull request Mar 12, 2024
Dragonfly BSD also supports getrandom/getentropy

FreeBSD bindings were added in rust-lang#1982

Signed-off-by: Joe Richey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants