feat: skip checking token tree count for include! macro call #15819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Nov 1, 2023
Member
|
Thanks a lot, I was actually planning to look into this! |
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This was referenced Nov 2, 2023
Veykril
reviewed
Nov 10, 2023
Comment on lines
+622
to
+633
| let skip_check_tt_count = match loc.kind { | ||
| MacroCallKind::FnLike { ast_id, expand_to: _ } => { | ||
| if let Some(name_ref) = | ||
| ast_id.to_node(db).path().and_then(|p| p.segment()).and_then(|s| s.name_ref()) | ||
| { | ||
| name_ref.as_name() == name!(include) | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
| _ => false, | ||
| }; |
Member
There was a problem hiding this comment.
This should check that the loc.def is the builtin include macro instead of doing a name check. Otherwise any macro called include skips the token limit check
bors
added a commit
that referenced
this pull request
Nov 10, 2023
Improve check for include macro #15819 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15335 #15648