Skip to content

Conversation

@c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Feb 9, 2023

Fix #10209


changelog: Enhancement: [arithmetic_side_effects]: No longer lints, if safe constant values are used.
#10310

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 9, 2023
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

Since the lint is doing a moderate amount of work it'd be worth adding an is_lint_allowed check in should_skip_expr

@c410-f3r
Copy link
Contributor Author

Thanks, looks good

Since the lint is doing a moderate amount of work it'd be worth adding an is_lint_allowed check in should_skip_expr

Done

@Alexendoo
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2023

📌 Commit 1ed8ed3 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 12, 2023

⌛ Testing commit 1ed8ed3 with merge 6f353fd...

@bors
Copy link
Contributor

bors commented Feb 12, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 6f353fd to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arithmetic_side_effects: can’t see through trivial constant items

4 participants