Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Mar 3, 2023

No tests at the moment. Need to find a way to write macro tests without writing a pile of macros.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 3, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dswij
Copy link
Member

dswij commented Mar 5, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2023

📌 Commit efbcb99 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 5, 2023

⌛ Testing commit efbcb99 with merge 783bc62...

@bors
Copy link
Contributor

bors commented Mar 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 783bc62 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 783bc62 to master...

@bors bors merged commit 783bc62 into rust-lang:master Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants