Added lints into_iter_on_ref and into_iter_on_array.
#3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
force-pushed
the
into-iter-on-array
branch
from
5f5ca79 to
281ff1d
Compare
oli-obk
reviewed
Oct 22, 2018
clippy_lints/src/methods/mod.rs
Outdated
| /// | ||
| /// **Why is this bad?** Arrays and `PathBuf` do not yet have an `into_iter` method which move out | ||
| /// their content into an iterator. Calling `into_iter` instead just forwards to `iter` or | ||
| /// `iter_mut` due to auto-referencing, of which only yield references. Furthermore, when the |
Contributor
There was a problem hiding this comment.
This sentence doesn't parse for me. I'm not sure what you're trying to say.
Member
There was a problem hiding this comment.
IIRC iter_mut doesn't directly apply, because it will always try and succeed with the immutable reference first, matching only iter.
Perhaps something like: "Auto-referencing resolves the into_iter call onto a container reference instead, like <&[T; N] as IntoIterator>::into_iter, which just iterates over item references like calling iter would."
oli-obk
approved these changes
Oct 23, 2018
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
Thanks! After reading the new text I understand what the old text was trying to say ;)
Contributor
|
Sorry for not getting around to merge this faster, could you rebase this for the README.md change? @kennytm |
kennytm
force-pushed
the
into-iter-on-array
branch
from
a67edf9 to
d824df1
Compare
Member
Author
|
@phansch Rebased, thanks! |
kennytm
force-pushed
the
into-iter-on-array
branch
from
d824df1 to
a44f41c
Compare
kennytm
force-pushed
the
into-iter-on-array
branch
from
a44f41c to
5563bd6
Compare
Contributor
|
bors r+ before another rebase is needed 😅 thanks! |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2018
3344: Added lints `into_iter_on_ref` and `into_iter_on_array`. r=phansch a=kennytm Fixes #1565. `into_iter_on_array` is a correctness lint against `into_iter()` on `[T; n]` and `PathBuf` (please provide a concise noun that covers both types 🙃). `into_iter_on_ref` is a style lint against `into_iter()` on `&C` where `C` is `[T]`, `Vec<T>`, `BTreeSet<T>` etc. Both suggests replacing the `into_iter()` with `iter()` or `iter_mut()`. `into_iter_on_array` is a correctness lint since it is very likely the standard library would provide an `into_iter()` method for `[T; n]` (rust-lang/rust#25725) and existing type inference of `[a, b, c].into_iter()` will be broken. `PathBuf` is also placed under this lint since `PathBuf::into_iter` currently doesn't exist and it makes some sense to implement `IntoIterator` on it yielding `OsString`s. Co-authored-by: kennytm <[email protected]>
Contributor
This was referenced Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565.
into_iter_on_arrayis a correctness lint againstinto_iter()on[T; n]andPathBuf(please provide a concise noun that covers both types 🙃).into_iter_on_refis a style lint againstinto_iter()on&CwhereCis[T],Vec<T>,BTreeSet<T>etc.Both suggests replacing the
into_iter()withiter()oriter_mut().into_iter_on_arrayis a correctness lint since it is very likely the standard library would provide aninto_iter()method for[T; n](rust-lang/rust#25725) and existing type inference of[a, b, c].into_iter()will be broken.PathBufis also placed under this lint sincePathBuf::into_itercurrently doesn't exist and it makes some sense to implementIntoIteratoron it yieldingOsStrings.