Use avoid-breaking-exported-api configuration in types module
#7560
Conversation
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
7289-configuration-for-every-type-lint
branch
from
309af43 to
e67c25d
Compare
camsteffen
left a comment
camsteffen
left a comment
There was a problem hiding this comment.
This is nice! Just some nits. Glad to see the config option extended.
(That's pretty much it, not really a change worthy of writing a fairy tale about. Don't get me wrong, I would love to write a short one, but I sadly need to study now).
Also this PR is blocked on missing fairy tale. 🤣
It wouldn't be the first Clippy PR with a fairy tale 😉. I can promise you that the next PR I assign to you will have a short one in it. Does this sound like a deal to you? |
camsteffen
left a comment
camsteffen
left a comment
There was a problem hiding this comment.
Looks good. Do you want to squash any commits?
Oh alright 😄 |
Addressed PR reviews regarding code style
xFrednet
force-pushed
the
7289-configuration-for-every-type-lint
branch
from
8465ba8 to
c02dcd5
Compare
Sure, why not 🙃 @bors r=camsteffen |
|
📌 Commit c02dcd5 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
4 participants
This PR empowers our lovely
avoid-breaking-exported-apiconfiguration value to also influence the emission of lints inside thetypesmodule.(That's pretty much it, not really a change worthy of writing a fairy tale about. Don't get me wrong, I would love to write a short one, but I sadly need to study now).
Closes: #7489
changelog: The
avoid-breaking-exported-apiconfiguration now also works for [box_vec], [redundant_allocation], [rc_buffer], [vec_box], [option_option], [linkedlist], [rc_mutex]changelog: [
rc_mutex]: update the lint message to comply with the normal formatr? @camsteffen, as you implemented the configuration value
cc: @flip1995, as we've discussed this change in #7308