Improve strlen_on_c_string
#8001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
unprefixed_strlen
branch
from
c550d0b to
6c23dc8
Compare
Jarcho
force-pushed
the
unprefixed_strlen
branch
from
6c23dc8 to
0d1f1ce
Compare
giraffate
reviewed
Nov 22, 2021
giraffate
suggested changes
Nov 25, 2021
Contributor
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Overall looks good. Can you address the failed tests?
Jarcho
force-pushed
the
unprefixed_strlen
branch
from
d32fcd3 to
a135347
Compare
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit a135347 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7436
changelog: lint
strlen_on_c_stringwhen used without a fully-qualified pathchangelog: suggest removing the surrounding unsafe block for
strlen_on_c_stringwhen possible