Skip to content

Enable unused_parens for match arms #100093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Aug 4, 2022
Merged

Enable unused_parens for match arms #100093

bors merged 1 commit into from
Aug 4, 2022

Conversation

@wcampbell0x2a
Copy link
Contributor

@wcampbell0x2a wcampbell0x2a commented Aug 3, 2022

Fixes: #92751

Currently I can't get the stderr to work with ./x.py test, but this should fix the issue. Help would be appreciated!

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 3, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Aug 3, 2022

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wcampbell0x2a wcampbell0x2a force-pushed the unused-parens-for-match-arms branch from 2c3638d to 9860dc1 Compare August 3, 2022 04:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wcampbell0x2a wcampbell0x2a force-pushed the unused-parens-for-match-arms branch from 9860dc1 to 1977176 Compare August 3, 2022 04:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Aug 3, 2022
View reviewed changes
@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 3, 2022

Currently I can't get the stderr to work with ./x.py test, but this should fix the issue. Help would be appreciated!

You can run x.py test --bless src/test/ui for the .stderr files to be updated automatically.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@wcampbell0x2a wcampbell0x2a force-pushed the unused-parens-for-match-arms branch from 1977176 to e1de8a6 Compare August 4, 2022 01:16
@wcampbell0x2a
Copy link
Contributor Author

wcampbell0x2a commented Aug 4, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2022
@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 4, 2022

r=me after squashing commits.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022
@wcampbell0x2a wcampbell0x2a force-pushed the unused-parens-for-match-arms branch from e1de8a6 to 8dd44f1 Compare August 4, 2022 11:17
@wcampbell0x2a
Copy link
Contributor Author

wcampbell0x2a commented Aug 4, 2022 •
edited
Loading

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2022
@wcampbell0x2a
Copy link
Contributor Author

wcampbell0x2a commented Aug 4, 2022

r=me after squashing commits. @rustbot author

I used @rustbot ready, I couldn't find anyone using @r=me or something that you requested?

@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 4, 2022

Thanks!
@bors r+

I couldn't find anyone using @r=me or something that you requested?

Ah, that's a message targeted at someone with approval rights (which may be me), that this PR can be approved on my behalf once the condition is satisfied.

@bors
Copy link
Collaborator

bors commented Aug 4, 2022

📌 Commit 8dd44f1 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2022
@bors
Auto merge of rust-lang#100151 - matthiaskrgr:rollup-irqwvj2, r=matth…
f6f9d5e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#98796 (Do not exclusively suggest `;` when `,` is also a choice)
 - rust-lang#99772 (Re-enable submodule archive downloads.)
 - rust-lang#100058 (Suggest a positional formatting argument instead of a captured argument)
 - rust-lang#100093 (Enable unused_parens for match arms)
 - rust-lang#100095 (More EarlyBinder cleanups)
 - rust-lang#100138 (Remove more Clean trait implementations)
 - rust-lang#100148 (RustWrapper: update for TypedPointerType in LLVM)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b938c8 into rust-lang:master Aug 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 4, 2022
@wcampbell0x2a wcampbell0x2a deleted the unused-parens-for-match-arms branch August 5, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

unused_parens doesn't fire for match arms

6 participants

@wcampbell0x2a @rust-highfive @rust-log-analyzer @petrochenkov @bors @rustbot