Use tcx.ty_error_with_guaranteed in more places, rename variants

[compiler-errors]

1. Use ty_error_with_guaranteed more so we don't delay so many span bugs
2. Rename ty_error_with_guaranteed to ty_error, ty_error to ty_error_misc. This is to incentivize using the former over the latter in cases where we already are witness to a ErrorGuaranteed token.

Second commit is just name replacement, so the first commit can be reviewed on its own with more scrutiny.

[rustbot]

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

[BoxyUwU]

r? @BoxyUwU

@bors r+ p=1 rollup=never because this seems like it might get very merge conflicted since any PR that touches ty_error or ty_error_with_guaranteed is gonna 💥 👀

[bors]

📌 Commit 298ae8c has been approved by BoxyUwU

It is now in the queue for this repository.

[bors]

⌛ Testing commit 298ae8c with merge 07c993e...

[bors]

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 07c993e to master...

[rust-timer]

Finished benchmarking commit (07c993e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.2%, -1.0%]	2
Improvements ✅ (secondary)	-2.2%	[-2.5%, -2.0%]	6
All ❌✅ (primary)	-1.1%	[-1.2%, -1.0%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.