Skip to content

Conversation

@JhonnyBillM
Copy link
Contributor

Removes monomorphization errors duplication by reusing the ones defined in codegen_ssa.

Also updates expected_simd errors usage in codegen_gcc by assuming we want to treat those parameters as translatable. See 7a888fb

Reduces error duplication and makes it more consistent across backends
Here I am assuming we want to treat these parameters (input, first, second, third, return) as translatable
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2023

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

@JhonnyBillM
Copy link
Contributor Author

@rustbot label +A-translation
r? rust-lang/diagnostics

@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Jul 20, 2023
@rustbot rustbot assigned davidtwco and unassigned cjgillot Jul 20, 2023
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 24, 2023

📌 Commit 7a888fb has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2023
@bors
Copy link
Collaborator

bors commented Jul 24, 2023

⌛ Testing commit 7a888fb with merge f475098...

@bors
Copy link
Collaborator

bors commented Jul 24, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing f475098 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2023
@bors bors merged commit f475098 into rust-lang:master Jul 24, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 24, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f475098): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.2%, 0.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.7% [3.7%, 3.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-2.2%, -1.6%] 2
All ❌✅ (primary) 3.7% [3.7%, 3.7%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.993s -> 651.432s (0.07%)

@JhonnyBillM JhonnyBillM deleted the reuse-codegen-ssa-monomorphization-errors-in-gcc branch July 24, 2023 22:23
antoyo pushed a commit to antoyo/rust that referenced this pull request Oct 9, 2023
…rphization-errors-in-gcc, r=davidtwco

Reuse `codegen_ssa` monomorphization errors in `codegen_gcc`

Removes monomorphization errors duplication by reusing the ones defined in `codegen_ssa`.

Also updates `expected_simd` errors usage in `codegen_gcc` by assuming we want to treat those parameters as translatable. See rust-lang@7a888fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants