make it more clear what 'Tier 2' (without host tools) means #115472

RalfJung · 2023-09-02T08:34:56Z

When saying that Rust "builds official binary releases for each tier 2 target", it's not at all clear that this does not mean we build a compiler and cargo for that target.

rustbot · 2023-09-02T08:35:01Z

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

GuillaumeGomez · 2023-09-02T09:21:41Z

Thanks!

@bors r+ rollup

bors · 2023-09-02T09:21:43Z

📌 Commit 89619b8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2023-09-02T14:36:06Z

⌛ Testing commit 89619b8 with merge 278249a324e2b9a6d16b0c13cd3f581eafdaf4dd...

rust-log-analyzer · 2023-09-02T14:44:59Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:18] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] / 
---
[01:16] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:16] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:16] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:16] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] /

bors · 2023-09-02T14:45:32Z

💔 Test failed - checks-actions

RalfJung · 2023-09-02T14:54:33Z

@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

bors · 2023-09-02T14:54:42Z

⌛ Testing commit 89619b8 with merge bd5616fc5a00c992ae71c80261cf80547697f995...

bors · 2023-09-02T15:01:57Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-09-02T15:02:43Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[00:11] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:11] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:11] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:11] / 
---
[00:22] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[00:22] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[00:22] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[00:22] / 
---
[01:18] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:18] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:18] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:18] / 
---
[01:19] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:19] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:19] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:19] / 
---
[01:17] / 
[ERROR]  >>        called from: CT_Fetch[scripts/functions@2201]

[01:17] / 
[ERROR]  >>        called from: do_isl_get[scripts/build/companion_libs/121-isl.sh@16]
[01:17] / 
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]

[01:17] /

RalfJung · 2023-09-02T15:05:06Z

Third time in a row that I see this failure. Seems to not go away by itself, so I'll close the tree.
@bors treeclosed=100
Cc @rust-lang/infra

RalfJung · 2023-09-02T15:05:24Z

Also once the tree is open again this PR should be tried again
@bors retry '/bin/sh -c /scripts/crosstool-ng-build.sh' returned a non-zero code: 1

bors · 2023-09-03T05:23:55Z

⌛ Testing commit 89619b8 with merge a989e25...

bors · 2023-09-03T07:10:53Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing a989e25 to master...

rust-timer · 2023-09-03T13:27:13Z

Finished benchmarking commit (a989e25): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-4.7%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.315s -> 628.29s (-0.16%)
Artifact size: 316.70 MiB -> 316.65 MiB (-0.01%)

make it more clear what 'Tier 2' (without host tools) means

89619b8

rustbot assigned GuillaumeGomez Sep 2, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2023

GuillaumeGomez approved these changes Sep 2, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2023

This was referenced Sep 2, 2023

fix the repetitive word #115441

Merged

Make .rmeta file in dep-info have correct name (lib prefix) #114750

Merged

bors mentioned this pull request Sep 2, 2023

Migrate GUI colors test to original CSS color format #115484

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023

bors merged commit a989e25 into rust-lang:master Sep 3, 2023

rustbot added this to the 1.74.0 milestone Sep 3, 2023

RalfJung deleted the tier-2 branch September 3, 2023 07:38

Uh oh!

make it more clear what 'Tier 2' (without host tools) means #115472

make it more clear what 'Tier 2' (without host tools) means #115472

Conversation

RalfJung commented Sep 2, 2023

Uh oh!

rustbot commented Sep 2, 2023

Uh oh!

GuillaumeGomez commented Sep 2, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

rust-log-analyzer commented Sep 2, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

RalfJung commented Sep 2, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

rust-log-analyzer commented Sep 2, 2023

Uh oh!

RalfJung commented Sep 2, 2023

Uh oh!

RalfJung commented Sep 2, 2023

Uh oh!

bors commented Sep 3, 2023

Uh oh!

bors commented Sep 3, 2023

Uh oh!

rust-timer commented Sep 3, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants