Skip to content

Conversation

@alexcrichton
Copy link
Member

  • Chan => Sender
  • Port => Receiver
  • Chan::new() => channel()
  • constructor returns (Sender, Receiver) instead of (Receiver, Sender)
  • local variables named port renamed to rx
  • local variables named chan renamed to tx

Closes #11765

@brson
Copy link
Contributor

brson commented Mar 10, 2014

Epic renaming.

* Chan<T> => Sender<T>
* Port<T> => Receiver<T>
* Chan::new() => channel()
* constructor returns (Sender, Receiver) instead of (Receiver, Sender)
* local variables named `port` renamed to `rx`
* local variables named `chan` renamed to `tx`

Closes rust-lang#11765
bors added a commit that referenced this pull request Mar 13, 2014
* Chan<T> => Sender<T>
* Port<T> => Receiver<T>
* Chan::new() => channel()
* constructor returns (Sender, Receiver) instead of (Receiver, Sender)
* local variables named `port` renamed to `rx`
* local variables named `chan` renamed to `tx`

Closes #11765
@bors bors closed this Mar 13, 2014
@bors bors merged commit 7858065 into rust-lang:master Mar 13, 2014
@alexcrichton alexcrichton deleted the chan-rename branch March 13, 2014 22:21
chris-morgan added a commit to chris-morgan/rust-http that referenced this pull request Mar 13, 2014
tedhorst added a commit to tedhorst/rust that referenced this pull request Mar 14, 2014
bors added a commit that referenced this pull request Mar 14, 2014
Fix a test that was missed in the chan/port renaming (PR #12815).  This was missed because it is skipped on linux and windows, and the mac bots were moving at the time the PR landed.
bors added a commit that referenced this pull request Mar 16, 2014
The same test was missed in chan/port renaming PR #12815 and was fixed in #12880:

> This was missed because it is skipped on linux and windows, and the mac bots were moving at the time the PR landed.

It seems the same happened to the liblog PR.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 13, 2024
…_iteration, r=xFrednet

Add `needless_character_iteration` lint

Fixes rust-lang#4817.

r? `@xFrednet`

changelog: Add `needless_character_iteration` lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename channel types and constructor

3 participants