uefi: Implement path #135475
Merged
uefi: Implement path #135475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
Ayush1325
force-pushed
the
uefi-absolute-path
branch
2 times, most recently
from
4549114 to
aeeb1fd
Compare
nicholasbishop
approved these changes
Jan 16, 2025
UEFI paths can be of 4 types: 1. Absolute Shell Path: Uses shell mappings 2. Absolute Device Path: this is what we want 3: Relative root: path relative to the current root. 4: Relative Absolute shell path can be identified with `:` and Absolute Device path can be identified with `/`. Relative root path will start with `\`. The algorithm is mostly taken from edk2 UEFI shell implementation and is somewhat simple. Check for the path type in order. For Absolute Shell path, use `EFI_SHELL->GetDevicePathFromMap` to get a BorrowedDevicePath for the volume. For Relative paths, we use the current working directory to construct the new path. BorrowedDevicePath abstraction is needed to interact with `EFI_SHELL->GetDevicePathFromMap` which returns a Device Path Protocol with the lifetime of UEFI shell. Absolute Shell paths cannot exist if UEFI shell is missing. Signed-off-by: Ayush Singh <[email protected]>
Ayush1325
force-pushed
the
uefi-absolute-path
branch
from
aeeb1fd to
c1790b1
Compare
Contributor
Author
|
cc @tgross35 |
Contributor
Author
|
r? @jhpratt |
Member
|
As a target maintainer has already given this the okay, this LGTM. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split off from #135368 to reduce noise.
UEFI paths can be of 4 types:
Absolute shell path can be identified with
:and Absolute Device path can be identified with/. Relative root path will start with\.The algorithm is mostly taken from edk2 UEFI shell implementation and is somewhat simple. Check for the path type in order.
For Absolute Shell path, use
EFI_SHELL->GetDevicePathFromMapto get a BorrowedDevicePath for the volume.For Relative paths, we use the current working directory to construct the new path.
BorrowedDevicePath abstraction is needed to interact with
EFI_SHELL->GetDevicePathFromMapwhich returns a Device Path Protocol with the lifetime of UEFI shell.Absolute Shell paths cannot exist if UEFI shell is missing.
cc @nicholasbishop