add min_pos_value constant for floats #13735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up on issue rust-lang#13297 and PR rust-lang#13710. Instead of following the (confusing) C/C++ approach of using `MIN_VALUE` for the smallest *positive* number, we introduce `MIN_POS_VALUE` (and in the Float trait, `min_pos_value`) to represent this number. This patch also removes a few remaining redundantly-defined constants that were missed last time around.
Contributor
Author
|
/cc @bjz |
Member
There was a problem hiding this comment.
Is there a different but still reasonable name for this? It may be confusing for someone who's used to C's weird definition and tries to use this constant without looking at the value.
Contributor
There was a problem hiding this comment.
This doesn't shock me since Rust tries to fix the C/C++ legacy in various domains... plus I would expect a newcomer to at least lookup the function name/doc on rustdoc.
Contributor
There was a problem hiding this comment.
C++11 introduced numeric_limits::lowest, but that's an ugly backwards compatibility workaround. So long as we document this, I think it is good to get this right from the start.
Contributor
|
Looks good! r+ from me. @brson? |
bors
added a commit
that referenced
this pull request
Apr 25, 2014
Follow-up on issue #13297 and PR #13710. Instead of following the (confusing) C/C++ approach of using `MIN_VALUE` for the smallest *positive* number, we introduce `MIN_POS_VALUE` (and in the Float trait, `min_pos_value`) to represent this number. This patch also removes a few remaining redundantly-defined constants that were missed last time around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on issue #13297 and PR #13710. Instead of following the (confusing) C/C++ approach
of using
MIN_VALUEfor the smallest positive number, we introduceMIN_POS_VALUE(andin the Float trait,
min_pos_value) to represent this number.This patch also removes a few remaining redundantly-defined constants that were missed last
time around.