Add DefId::parent() accessor for rustc_public
#144000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
Member
|
Thanks! Could you please add an ui-test for that, if it's not too much work |
Member
|
Sorry, while I volunteered to help with reviews here I don't really know intent for stuff like this, so re-rolling |
celinval
requested changes
Jul 25, 2025
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
It looks good. Can you please add a test to the new API? You can just augment https://github.com/rust-lang/rust/blob/master/tests/ui-fulldeps/rustc_public/check_defs.rs
r=me when you are done
celinval
approved these changes
Jul 25, 2025
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
oops... wrong checkbox.
Contributor
|
r? celinval |
Dylan-DPC
added
S-waiting-on-author
Member
|
@jacob-greenfield can you add the test required for this? that's the only thing pending here. |
Collaborator
|
☔ The latest upstream changes (presumably #148280) made this pull request unmergeable. Please resolve the merge conflicts. |
jacob-greenfield
force-pushed
the
stable-defid-parent
branch
from
7a32307 to
e9d68a5
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
I've added a new/separate UI test based on |
Contributor
|
Hmmm.. let me try again. @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Nov 29, 2025
Rollup merge of #144000 - jacob-greenfield:stable-defid-parent, r=celinval Add `DefId::parent()` accessor for `rustc_public` Adds a `parent()` method to `DefId` (the `rustc_pub` version) which exposes the parent path, ie. `foo::bar::baz` -> `foo::bar`. This is useful for organizing/grouping definitions into a tree, and is probably simpler and less brittle than attempting to parse the fully-qualified name into path components (e.g. especially when handling path components with qualified generic parameters).
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Dec 10, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang/rust#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang/rust#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
…nt, r=celinval Add `DefId::parent()` accessor for `rustc_public` Adds a `parent()` method to `DefId` (the `rustc_pub` version) which exposes the parent path, ie. `foo::bar::baz` -> `foo::bar`. This is useful for organizing/grouping definitions into a tree, and is probably simpler and less brittle than attempting to parse the fully-qualified name into path components (e.g. especially when handling path components with qualified generic parameters).
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
Rollup of 3 pull requests Successful merges: - rust-lang#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
parent()method toDefId(therustc_pubversion) which exposes the parent path, ie.foo::bar::baz->foo::bar.This is useful for organizing/grouping definitions into a tree, and is probably simpler and less brittle than attempting to parse the fully-qualified name into path components (e.g. especially when handling path components with qualified generic parameters).